This repository has been archived by the owner on May 6, 2020. It is now read-only.
Capabilities: Limit the list of capabilities #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the list of capabilities to the same subset as runc Fixes clearcontainers/runtime#818 Signed-off-by: Manohar Castelino <[email protected]>
|
The code is fine, but I am wondering if that's what we want cause right now we don't have support for adding capabilities and I always thought that this change (your PR) should come along with the support of adding a list of capabilities from the config.json provided. |
|
@sboeuf it should not change anything. We run unpriv containers. So we are actually providing CAPs that should not have been provided in the first place. |
|
LGTM
|
sboeuf
approved these changes
Nov 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the list of capabilities to the same subset as runc
Fixes clearcontainers/runtime#818
Signed-off-by: Manohar Castelino [email protected]