This repository has been archived by the owner on May 6, 2020. It is now read-only.
pause: Rewrite pause binary in go. #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
force-pushed
the
rewrite-pause-binary-in-go
branch
from
15dd41f to
ba8ee8c
Compare
This was referenced Aug 17, 2017
|
LGTM |
|
Hi @iphutch - please could you review? |
|
lgtm
|
|
@jodh-intel in Makefile please remove |
Requiring a statically-linked C program causes problems on some platforms (such as RHEL). Fixes clearcontainers#433. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
rewrite-pause-binary-in-go
branch
from
ba8ee8c to
9f3ca75
Compare
|
@gorozco1 - good catch! Done. |
1 similar comment
|
👍 merge, merg, merge!! |
jodh-intel
added a commit
to jodh-intel/runtime
that referenced
this pull request
Sep 25, 2017
The script ".ci/go-static-checks.sh" was trying to exclude all vendor files and files below pause/. However, the logic was incorrect meaning the only file actually being gofmt-checked was pause.go! Since the pause binary is now written in go [1], in fact we only want to exclude "vendor/*" files. --- [1] - clearcontainers#434 Fixes clearcontainers#624. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/runtime
that referenced
this pull request
Sep 25, 2017
The script ".ci/go-static-checks.sh" was trying to exclude all vendor files and files below pause/. However, the logic was incorrect meaning the only file actually being gofmt-checked was pause.go! Since the pause binary is now written in go [1], in fact we only want to exclude "vendor/*" files. --- [1] - clearcontainers#434 Fixes clearcontainers#624. Signed-off-by: James O. D. Hunt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring a statically-linked C program causes problems on some
platforms (such as RHEL).
Fixes #433.
Signed-off-by: James O. D. Hunt [email protected]