implement TLSSocket and connect from node:tls #3594
+1,223
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/introduce-tls
branch
2 times, most recently
from
1fb6373 to
e77192f
Compare
|
The generated output of |
|
Nice! |
anonrig
force-pushed
the
yagiz/introduce-tls
branch
8 times, most recently
from
7968547 to
a8848ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anonrig
force-pushed
the
yagiz/introduce-tls
branch
11 times, most recently
from
5c957db to
57490be
Compare
anonrig
force-pushed
the
yagiz/introduce-tls
branch
3 times, most recently
from
b37c0b7 to
ccbf33f
Compare
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
ccbf33f to
30b394c
Compare
npaun
reviewed
Feb 28, 2025
anonrig
force-pushed
the
yagiz/introduce-tls
branch
3 times, most recently
from
c098331 to
9e499da
Compare
jasnell
reviewed
Mar 3, 2025
jasnell
reviewed
Mar 3, 2025
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
9e499da to
7da4321
Compare
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
7da4321 to
c07f938
Compare
jasnell
reviewed
Mar 3, 2025
| public [kPendingSession]: null | Buffer; | ||
| public [kErrorEmitted]: boolean; | ||
| public [kDisableRenegotiation]: boolean; | ||
| public [kPskCallback]?: TlsOptions['pskCallback']; |
There was a problem hiding this comment.
We know that we're not going to be supporting things like renegotiation and pre-shared key callbacks so I'm not sure it makes any sense to include these.
| this.on('close', onSocketCloseDestroySSL); | ||
| } | ||
|
|
||
| wrap?.on('close', () => this.destroy()); |
| // Guard against adding multiple listeners, as this method may be called | ||
| // repeatedly on the same socket by reinitializeHandle | ||
| if (this.listenerCount('close', onSocketCloseDestroySSL) === 0) { | ||
| this.on('close', onSocketCloseDestroySSL); |
| // Let's disable floating promises error. | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| socket?._handle?.socket.opened.then(this._finishInit.bind(this)); | ||
| socket?.on('error', onerror.bind(this)); |
| }); | ||
| } | ||
|
|
||
| wrap?.on('error', (err: Error): void => { |
| this._tlsOptions.handshakeTimeout > 0 | ||
| ) | ||
| this.setTimeout(0, this._handleTimeout.bind(this)); | ||
| this.emit('secure'); |
There was a problem hiding this comment.
Node.js will often emit events using process.nextTick(...) to defer execution. Is that needed on these?
| // This means that options.host overrides a host arg. | ||
| if (listArgs[1] !== null && typeof listArgs[1] === 'object') { | ||
| Object.assign(options, listArgs[1]); | ||
| } else if (listArgs[2] !== null && typeof listArgs[2] === 'object') { |
There was a problem hiding this comment.
Fun fact... you don't need the !== null check here. Object.assign(options, null) is handled just fine. In fact, you could get by without any type check here.
| this[kIsVerified] = true; | ||
| const session = this[kPendingSession]; | ||
| this[kPendingSession] = null; | ||
| if (session) this.emit('session', session); |
There was a problem hiding this comment.
Another one... should these be wrapped in process.nextTick/queueMicrotask?
jasnell
reviewed
Mar 3, 2025
Comment on lines
+40
to
+45
| try { | ||
| await once(socket, 'close'); | ||
| fail(`close ${testName} should have thrown`); | ||
| } catch (err) { | ||
| strictEqual(err.name, 'AbortError'); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's extremely early to even open this, but people have been asking about the progress, and what better way to show progress than the actual code (with a public pr)