Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

test: Fix compile error with go1.10.2 #941

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

amshinde
Copy link
Contributor

@amshinde amshinde commented Oct 8, 2018

Replace Skip with Skipf in the intergration test.

Signed-off-by: Archana Shinde [email protected]

Replace Skip with Skipf in the intergration test.

Signed-off-by: Archana Shinde <[email protected]>
@k8s-ci-robot
Copy link

Hi @amshinde. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
Thanks!

@Random-Liu
Copy link
Member

/lgtm

The failure is caused by golang version issue. I'll update the test-infra.

@Random-Liu
Copy link
Member

Let's wait for kubernetes/test-infra#9736.

@amshinde
Copy link
Contributor Author

amshinde commented Oct 8, 2018

@Random-Liu I see the pull-cri-containerd-verify tests failing. Do these need to be rerun or is this a valid failure?

@Random-Liu
Copy link
Member

/test pull-cri-containerd-verify

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants