V0.2.2 + back-ported [plugins/bridge: clean masquerading rules] #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script uses rkt and a fedora image to build release tarballs.
* use SHA1 instead of MD5
For two reasons: 1. They're not functional within rkt 2. They rebuild the binaries dynamically
In the Add command we set up masquerading rules that didn't have a corresponding clean-up code in Del. Add the clean-up code.
|
I think we need #177 too to fix rkt/rkt#1765 for the nspawn flavor. |
|
@iaguis Alright I'll turn this into |
|
nope, not that I can think of |
|
Let's hold off on that one for now. #2565 is a lot more critical. |
|
@tmrts github is confusing me - is this against v0.2.2, even though it says "tmrts wants to merge 6 commits into containernetworking:master from tmrts:v0.2.2"? |
|
@jonboulle I specifically selected a new branch, I'll make sure that's the case before merging |
|
@jonboulle as it turns out, I can't even push a PR to a non-existant branch without write access. |
|
Closing in favor of #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #195 to v0.2.2, which is a fix for iptable rule leaks in rkt (See rkt#2565)