imagebuildah: make scratch config handling toggleable #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/api-change
|
LGTM |
openshift-merge-robot
added
the
needs-rebase
nalind
force-pushed
the
compat-scratch-config
branch
from
9a0adb4 to
9d5bba0
Compare
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nalind
force-pushed
the
compat-scratch-config
branch
from
9d5bba0 to
1002251
Compare
|
Pretty sure this will fix the conformance test failures in #5688. |
nalind
force-pushed
the
compat-scratch-config
branch
3 times, most recently
from
2f874a4 to
a060efd
Compare
|
LGTM |
nalind
force-pushed
the
compat-scratch-config
branch
from
a060efd to
8613dcd
Compare
The default configuration that `docker build` applies to images built using "scratch" has changed from classic builds to BuildKit. Add a toggle for selecting which behavior to mimic. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
compat-scratch-config
branch
from
8613dcd to
f88579d
Compare
|
Rebased. |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
The default configuration that
docker buildapplies to images built using "scratch" has changed from classic builds to BuildKit. Add a toggle for selecting which behavior to mimic.How to verify it
Updated conformance test cases!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?