Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.33] tag v1.33.12 #5921

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

nalind
Copy link
Member

@nalind nalind commented Jan 20, 2025

What type of PR is this?

/kind other

What this PR does / why we need it:

Tag a v1.33.12 release to incorporate the recent security update.

How to verify it

The test suite should be enough.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Changes made in locations mounted using `--mount=type=bind` in RUN instructions in `buildah build` and specified to `buildah run` are now discarded.

@nalind nalind force-pushed the v1.33.12 branch 3 times, most recently from 16be634 to abd93b2 Compare January 20, 2025 18:31
@TomSweeneyRedHat
Copy link
Member

Debian isn't happy test wise, I'm not sure if that's expected in this branch or not.

Add an always-fails MountWithOptions for platforms that don't support
overlay mounting, so that cross-compilations will work again.

Switch overlay.Unmount() to not use per-platform extensions, for the
same reason.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Tag a new release to incorporate the recent security advisory, and make
a minor update to the CI configuration.

[NO NEW TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jan 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 58af1cd into containers:release-1.33 Jan 21, 2025
29 checks passed
@nalind nalind deleted the v1.33.12 branch January 21, 2025 15:37
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Jan 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants