Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_freebsd.go: only import runtime-spec once #5935

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

nalind
Copy link
Member

@nalind nalind commented Jan 22, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The github.com/opencontainers/runtime-spec/specs-go module was being imported twice, once with a non-default package name, and once with its default name, which is more than we needed.

How to verify it

No functional changes, the cross-compile check should be enough.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 22, 2025
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The github.com/opencontainers/runtime-spec/specs-go module was being
imported twice, once with a non-default package name, and once with its
default name, which is more than we needed.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind added the No New Tests Allow PR to proceed without adding regression tests label Jan 22, 2025
@rhatdan
Copy link
Member

rhatdan commented Jan 23, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 17edf29 into containers:main Jan 23, 2025
32 checks passed
@nalind nalind deleted the specs branch January 23, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants