Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outbound_addr to allow for SNAT instead of MASQ #1180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lto-dev
Copy link

@lto-dev lto-dev commented Feb 15, 2025

Added outbound_addr to the bridge driver.

I created a bridge-snat plugin to use this feature and do SNAT instead of MASQUERADE on certain networks since i have multiple public ip's on same machine and i needed the traffic to go out on them and not on the gateway.
I can share the plugin as well if anyone wants it.

Copy link
Contributor

openshift-ci bot commented Feb 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lto-dev
Once this PR has been reviewed and has the lgtm label, please assign lsm5 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add proper integration test in test/ for both iptables and nftables

I have not yet looked into the rules that are added and if they are correct

Also I think this would need to be added to the firewalld code as well cc @mheon

@lto-dev
Copy link
Author

lto-dev commented Feb 17, 2025

let me know if the modifications are ok

@lto-dev lto-dev requested a review from Luap99 February 19, 2025 17:40
@Luap99
Copy link
Member

Luap99 commented Feb 25, 2025

Note I do not have time to properly review the rules right now. However please make sure your commits make sense as individual unit. Currently they are pretty meaningless so I suggest you squash everything into one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants