[skip-ci] TMT: initial enablement #820
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Feel free to ignore this PR until I ping you. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT integration tests failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT integration tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT integration tests failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
1 similar comment
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT integration tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT integration tests failed. @containers/packit-build please check. |
|
TMT validate test failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
|
TMT integration tests failed. @containers/packit-build please check. |
|
TMT unit tests failed. @containers/packit-build please check. |
lsm5
force-pushed
the
packit-tmt
branch
7 times, most recently
from
31bc099 to
436631e
Compare
lsm5
force-pushed
the
packit-tmt
branch
2 times, most recently
from
b02370d to
92a4f0b
Compare
Makefile
Outdated
| # The TEST_PLUGINS envvar is used by bats to specify path to test-plugins | ||
| # directory | ||
| ifdef TEST_PLUGINS | ||
| $(info Skipping examples build as TEST_PLUGINS is set) | ||
| integration: $(CARGO_TARGET_DIR) | ||
| else | ||
| integration: $(CARGO_TARGET_DIR) examples | ||
| endif |
There was a problem hiding this comment.
Maybe we should just drop the examples dependency instead of making it more complicated. We do not depend on build either so it is not much different.
| Requires: %{name} = %{epoch}:%{version}-%{release} | ||
|
|
||
| %description tests | ||
| %{summary} |
There was a problem hiding this comment.
We had this discussion recently about the podman RHEL rpm that this is not supported. So we should make sure if this ever gets top RHEL we do not ship it outside of the gating env if possible (i.e. follow whatever we decided to do with the podman rpm).
Outside of the bats test we do not support these examples either upstream. So maybe add the description here that these are test only binaries for gating and not recommended/supported for any other use.
lsm5
force-pushed
the
packit-tmt
branch
3 times, most recently
from
30b1e5b to
6e98139
Compare
|
cs10 blocked on bridge-utils absence: https://bugzilla.redhat.com/show_bug.cgi?id=2334212 |
lsm5
force-pushed
the
packit-tmt
branch
7 times, most recently
from
0db8f31 to
a588807
Compare
@lsm5 FYI I don't think we need that package here since 71d8a5a So just drop the dep. |
This commit adds `validate`, `unit`, and `integration` tests using for aarch64 and x86_64 arches on all active Fedora and CentOS Stream versions. Also includes podman revdep test contributed for c9s by Yuhui Jiang <[email protected]>. Ref: https://gitlab.com/redhat/centos-stream/rpms/netavark/-/merge_requests/59 Signed-off-by: Lokesh Mandvekar <[email protected]>
|
/packit retest-failed |
|
@Luap99 iptables tests are failing on F41+ and CS10. Should iptables be installed or these tests skipped? |
We should test all so we need to install them all but I think you are already doing that. The main issue is that the rpm uses a different default then what a regular from source build does. So the test must be fixed to work regardless of what driver is sued as default. Then there is a second issue AFAIK centos 10 dropped iptables support so the iptables tests cannot run there at all so we need to figure out how to skip only the iptables based tests there. And then I see another firewald driver issue, I think @mheon firewalld code requires a relatively recent firewalld so they might have to be skipped on centos 9 So overall quite a few things to figure out |
For local runs:
tmt run --allwill by default spawn virtual machines for running each test.tmt run --all provision --how localwill run tests on the local machine.The test run will echo the results dir at the very beginning. The actual results can be found in:
$TEST_RESULTS_DIR/plans/$TEST_NAME/execute/data/guest/default-0/script-00-1/output.txtso for example:
/var/tmp/tmt/run-022/plans/validate_test/execute/data/guest/default-0/script-00-1/output.txt