-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Updated Troubleshooting.md Closes #5431 #11249
[CI:DOCS] Updated Troubleshooting.md Closes #5431 #11249
Conversation
Gitvalidation is complaining about a signoff - can you add one with |
You have to sign your commits, could you please sign and fix your commit message to something useful, git commit -a --amend -s |
@TomSweeneyRedHat PTAL |
4ef1cb3
to
2f7cd62
Compare
LGTM, although you should put the closes #5431 in the body of the commit, not in the heading. |
Oh, I didn't know about the Commit heading and body part can I do a |
Yes. |
…loads Closes containers#5431 Signed-off-by: afro-coder <[email protected]>
2f7cd62
to
970529b
Compare
LGTM |
/lgtm |
Thanks @afro-coder |
Thank you for being so patient with me |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afro-coder, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi,
I didn't know what to do to remove the previous commits that had the whitespace issue so I deleted the branch itself.
This is a fresh branch I've checked with 3 different methods, including the commands from the vim wiki for trailing whitespaces but I couldn't find any.
I'm hoping this doesn't fail.
Closes #5431