Atomic level feature draft #2784
Conversation
| else { | ||
| float tan = dy / dx; | ||
| float at = atan(tan); | ||
| angle = (dx < 0) ? PI / 2 + at : -PI / 2 + at; |
There was a problem hiding this comment.
might be good idea to specify that function finds angle between point and Y axis. also, I believe atan2 is prefered
There was a problem hiding this comment.
@drizhina Yes, thanks. Possibly will refine all rotation to rays not setions as well
There was a problem hiding this comment.
I think you could use float Vec2f::tiltAngle()
| return str; | ||
|
|
||
| size_t detectionDomain = str.size() - substr.size() + 1; | ||
| detectionDomain = (substr == "\\t" || substr == "\\r" || substr == "\n") ? detectionDomain + 1 : detectionDomain; |
There was a problem hiding this comment.
Are you sure about \\n and \\r, but \n (only one \)?
| std::string res; | ||
| for (size_t i = 0; i < str.size(); ++i) { | ||
| if (stop) { | ||
| res += str[i]; |
There was a problem hiding this comment.
Can't we do str.replace(...) to avoid multiple allocations?
There was a problem hiding this comment.
I will refine to classical str replace as additional feature of replace first is not required any more
|
A couple of items before proceeding. @AliaksandrDziarkach, @vanoprenko FYI
|
|
Remove-me-sectionAtomic level feature draft