Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate regex in system.go for -check-requirements #1139

Merged
merged 1 commit into from
May 27, 2024
Merged

Remove duplicate regex in system.go for -check-requirements #1139

merged 1 commit into from
May 27, 2024

Conversation

redanaheim
Copy link
Contributor

This fixes a minor issue where the same line is displayed twice in opensnitchd -check-requirements:

Checking system requirements for kernel version 6.8.9-asahi
------------------------------------------------------------------------------

        Checking => CONFIG_KPROBES=y
        Checking => CONFIG_KPROBES_ON_FTRACE=y
         - KPROBES not fully supported by this kernel.
        Checking => CONFIG_KPROBES_ON_FTRACE=y
         - KPROBES not fully supported by this kernel.

gustavo-iniguez-goya
gustavo-iniguez-goya reviewed May 27, 2024
View reviewed changes
daemon/rule/operator.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @redanaheim , this change is not related to this PR. Create a new PR for it if you think it improves rules parsing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I just happened to commit those on my fork and forgot it would affect this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavo-iniguez-goya fixed.

@gustavo-iniguez-goya gustavo-iniguez-goya merged commit 5234df7 into evilsocket:master May 27, 2024
@gustavo-iniguez-goya
Copy link
Collaborator

thank you @redanaheim !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-iniguez-goya gustavo-iniguez-goya gustavo-iniguez-goya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redanaheim @gustavo-iniguez-goya