Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ ref(metric alerts): refactor get_metric_issue_aggregates #86266

Draft
wants to merge 3 commits into
base: raj/aci/refactor-incident-logic-2
Choose a base branch
from

Conversation

iamrajjoshi
Copy link
Member

continuing refactors for aci metric alerts, this time get_metric_issue_aggregates

@iamrajjoshi iamrajjoshi self-assigned this Mar 4, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...egrations/discord/message_builder/metric_alerts.py 80.00% 1 Missing ⚠️
...ations/msteams/card_builder/incident_attachment.py 80.00% 1 Missing ⚠️
src/sentry/integrations/opsgenie/utils.py 75.00% 1 Missing ⚠️
src/sentry/integrations/pagerduty/utils.py 75.00% 1 Missing ⚠️
...ry/integrations/slack/message_builder/incidents.py 80.00% 1 Missing ⚠️
src/sentry/rules/actions/notify_event_service.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           raj/aci/refactor-incident-logic-2   #86266   +/-   ##
==================================================================
  Coverage                              87.88%   87.88%           
==================================================================
  Files                                   9708     9708           
  Lines                                 550435   550488   +53     
  Branches                               21433    21433           
==================================================================
+ Hits                                  483769   483822   +53     
  Misses                                 66287    66287           
  Partials                                 379      379           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant