Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 chore(aci): skip creating broken actions if not in a dry run #86267

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iamrajjoshi
Copy link
Member

when we run the real migration script for issue alerts, we don't want to fail loudly for actions that can't be migrated
(reasons include sentry app installation not existing, missing fields, etc.)

instead, we will log errors and just skip over migrating those actions.

@iamrajjoshi iamrajjoshi self-assigned this Mar 4, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...y/workflow_engine/migration_helpers/rule_action.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #86267      +/-   ##
==========================================
- Coverage   87.87%   87.87%   -0.01%     
==========================================
  Files        9721     9721              
  Lines      551099   551119      +20     
  Branches    21478    21478              
==========================================
+ Hits       484283   484297      +14     
- Misses      66462    66468       +6     
  Partials      354      354              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant