Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error response structure and metadata #3845

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

moul
Copy link
Member

@moul moul commented Feb 27, 2025

Adds a vm.version={version} when the VM returns an error response.

Alternatively, we could simplify access to the version and other metadata, possibly with a "gnokey maketx --debug" command. However, I believe this addition is light enough to be included as a built-in feature.

@moul moul self-assigned this Feb 27, 2025
@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Feb 27, 2025
@moul moul changed the title dev/moul/err metadata chore: improve error reporting structure and metadata Feb 27, 2025
@moul moul changed the title chore: improve error reporting structure and metadata chore: improve error response structure and metadata Feb 27, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 27, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/crypto/keys/client/maketx.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@moul moul marked this pull request as ready for review February 27, 2025 15:47
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Mar 1, 2025
@thehowl thehowl merged commit dc62b18 into gnolang:master Mar 1, 2025
77 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants