Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GitLab documentation #5497

Merged
merged 2 commits into from
Mar 3, 2025
Merged

docs: add GitLab documentation #5497

merged 2 commits into from
Mar 3, 2025

Conversation

nachtjasmin
Copy link
Contributor

@nachtjasmin nachtjasmin commented Mar 3, 2025

Since there's some kind of official documentation for this, I decided to link it.

edit: we could even link to the official "CI/CD component" if wanted.

Copy link

boring-cyborg bot commented Mar 3, 2025

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title docs(integrations): add GitLab documentation docs: add GitLab documentation Mar 3, 2025
@ldez ldez added the area: docs label Mar 3, 2025
@ldez ldez self-requested a review March 3, 2025 12:12
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I think the content of "CI Integration" should be replaced by a link to https://golangci-lint.run/welcome/install/#ci-installation

And your modifications should be moved to this section.

@ldez ldez added the feedback required Requires additional feedback label Mar 3, 2025
@ldez ldez added enhancement New feature or improvement and removed feedback required Requires additional feedback labels Mar 3, 2025
@ldez ldez added this to the unreleased milestone Mar 3, 2025
@nachtjasmin
Copy link
Contributor Author

Just added one additional note about the domain of CI components, just so that self-hosted users do not have to search for that in the GitLab documentation first.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit d0ec328 into golangci:master Mar 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants