feat: #15237 toggle password visibility on shared albums #15238
Conversation
imakida
changed the title
There was a problem hiding this comment.
There's already a PasswordField component, please use that instead. https://github.com/immich-app/immich/blob/main/web/src/lib/components/shared-components/password-field.svelte
|
@bo0tzz Thanks for reviewing my PR. I made the changes you requested. I did add some e2e tests, are they enough? |
| <form class="flex" novalidate autocomplete="off" {onsubmit}> | ||
| <div class="relative mr-2"> |
There was a problem hiding this comment.
I don't think you need the changes here either, right? Get rid of the class="flex" on the form and remove the div again.
There was a problem hiding this comment.
The class="flex" on the form is to place the password input and the submit button on the same row per the original design. The PasswordField component is a div so it pushes the button into the next row if the form is not a flexbox.
It looks like I can get rid of <div class="relative mr-2"> that wraps the password field and move the margin to onto the button <Button class="ml-2" ...>.
There was a problem hiding this comment.
I know what that flex is. I just didn't see how swapping the input with the password component would make the difference here. If it's required though we obv can keep it, thus the question :)
Instead of ml/mr I'd rather work with gap I think.
There was a problem hiding this comment.
Great. That makes sense. Thanks for the input. I removed the margins and set the column gap.
…mmich-app#15238) * feat: toggle password visibility on shared albums * feat: toggle password visibility on shared albums * use password-field component * remove div wrapping PasswordField --------- Co-authored-by: Ian <[email protected]>
…mmich-app#15238) * feat: toggle password visibility on shared albums * feat: toggle password visibility on shared albums * use password-field component * remove div wrapping PasswordField --------- Co-authored-by: Ian <[email protected]>
…mmich-app#15238) * feat: toggle password visibility on shared albums * feat: toggle password visibility on shared albums * use password-field component * remove div wrapping PasswordField --------- Co-authored-by: Ian <[email protected]>
No description provided.