fix: include live images in person view count #16116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the total image count in the person view excluded live images. The query now correctly accounts for all relevant assets by removing the condition that filtered out assets with a
livePhotoVideoId
.Root Cause
The issue occurs because the original query included a condition to exclude assets with a
livePhotoVideoId
(i.e., live images), which led to an inaccurate image count. As a result, only static images were included in the count under a person’s name.Solution
.on('assets.livePhotoVideoId', 'is', null)
from the LEFT JOIN clause.This fix ensures that both live and static images are considered when counting the total number of images under a person’s profile.
Fixes #16094
How Has This Been Tested?
This PR has been tested on the following platforms:
Before the Fix:
After the Fix:
Further Considerations
Checklist: