-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add path to metadata logging #16212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. With an id they can quickly go to /photos/:id
and check the asset out. With the path they'd need to dig in the folder structure, which is especially annoying if you're not using the storage template or an external library.
I personally would prefer that we log both? It’s a lot easier to work with the database or view the asset on the web view using the ID |
Fair points. I first thought of logging path for external assets and id for others, but I didn't want to make exceptions like that. I'll let you guys decide what to do here |
I prefer logging the ID and don't think we need to log the original path as well, which is quite verbose. |
I am fine with logging both id and path for the sake of traceability |
e16a551
to
55a5729
Compare
I've updated the PR with your suggestion, please see the original PR description for an example |
cc9b7af
to
cf2158a
Compare
cf2158a
to
f562c73
Compare
This PR adds path information to most log statements made by the metadata service. This makes it easier to see which files have broken metadata, especially with external libraries.
Example:
I've also reworked and clarified some log statements