Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

devices cgrup doesn't reflect the right list of devices #351

Closed
devimc opened this issue Aug 31, 2018 · 0 comments · Fixed by #352
Closed

devices cgrup doesn't reflect the right list of devices #351

devimc opened this issue Aug 31, 2018 · 0 comments · Fixed by #352
Assignees
@devimc
Labels
bug Incorrect behaviour

Comments

@devimc
Copy link

devimc commented Aug 31, 2018

Since host device's major-minor numbers are mapped to guest numbers, the list of resources must be updated to apply devices constraints correctly.

more info see kata-containers/runtime#677
@devimc devimc added the bug Incorrect behaviour label Aug 31, 2018
@devimc devimc self-assigned this Aug 31, 2018
devimc pushed a commit to devimc/kata-agent that referenced this issue Aug 31, 2018
agent: update resources list with the right device major-minor number
3b6cced 
Host device's major-minor numbers are mapped to guest major-minor numbers,
for example in the host the major-minor number for /dev/loop0p1 is 259:1,
when it's attached to the VM now the major-minor number is 8:0, these
conversion must be reflected in devices and resources lists, the first list
is used to mount the device in the container and the second one is to update
the devices cgroup.

fixes kata-containers#351

Signed-off-by: Julio Montes <[email protected]>
@devimc devimc mentioned this issue Aug 31, 2018
Merged
@egernst egernst added the review label Aug 31, 2018
devimc pushed a commit to devimc/kata-agent that referenced this issue Sep 5, 2018
agent: update resources list with the right device major-minor number
fcf6fa7 
Host device's major-minor numbers are mapped to guest major-minor numbers,
for example in the host the major-minor number for /dev/loop0p1 is 259:1,
when it's attached to the VM now the major-minor number is 8:0, this
conversion must be reflected in devices and resources lists, the first list
is used to mount the device in the container and the second one is to update
the devices cgroup.

fixes kata-containers#351

Signed-off-by: Julio Montes <[email protected]>
@egernst egernst removed the review label Sep 5, 2018
jshachm pushed a commit to jshachm/agent that referenced this issue Nov 22, 2018
@jshachm
agent: update resources list with the right device major-minor number
d1abf91 
Host device's major-minor numbers are mapped to guest major-minor numbers,
for example in the host the major-minor number for /dev/loop0p1 is 259:1,
when it's attached to the VM now the major-minor number is 8:0, this
conversion must be reflected in devices and resources lists, the first list
is used to mount the device in the container and the second one is to update
the devices cgroup.

fixes kata-containers#351

Signed-off-by: Julio Montes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devimc devimc

Labels
bug Incorrect behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

agent: update resources list with the right device major-minor number devimc/kata-agent
2 participants
@devimc @egernst