Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

docs: Clarify security boundaries in privileged mode #452

Merged
merged 2 commits into from
May 7, 2019
Merged

docs: Clarify security boundaries in privileged mode #452

merged 2 commits into from
May 7, 2019

Conversation

leoluk
Copy link
Contributor

@leoluk leoluk commented May 2, 2019

@leoluk leoluk requested a review from a team as a code owner May 2, 2019 00:08
grahamwhaley
grahamwhaley reviewed May 2, 2019
View reviewed changes
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leoluk - thanks for your contribution!
I've left a couple of comments. You'll need to tweak the PR a little to meet our PR requirements so the CI is happy - please see https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#pull-requests for details.
I opened an Issue for you to reference in your commit 'Fixes' line for instance - #453

@grahamwhaley grahamwhaley mentioned this pull request May 2, 2019
Closed
@leoluk
Copy link
Contributor Author

leoluk commented May 2, 2019

Sure, updated the PR.

@leoluk leoluk changed the title Mention the fact that privileged mode passes host devices to container docs: Clarify security boundaries in privileged mode May 2, 2019
leoluk added 2 commits May 2, 2019 11:32
@leoluk
Copy link
Contributor Author

leoluk commented May 2, 2019

Some feedback: That was a lot of work for a minor drive-by documentation change. I had to find and read the source code to understand this error message and get past the CI:

https://github.com/kata-containers/tests/blob/master/cmd/checkcommits/checkcommits.go#L251-L253

@grahamwhaley
Copy link
Contributor

/test
Thanks @leoluk - I know it's a high entry barrier for tiny changes, but it has served the project well in maintaining the quality of review and therefore code, and the CI has saved our necks a number of times :-)
If you have any suggestion (or PRs ;-) ) to improve the docs or that piece of code, feel free to drop them by...

@grahamwhaley grahamwhaley requested a review from amshinde May 3, 2019 15:47
@leoluk
Copy link
Contributor Author

leoluk commented May 6, 2019

Not disagreeing, just pointing it out :)

PR good to merge?

jodh-intel
jodh-intel approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @leoluk!

lgtm

@jodh-intel jodh-intel merged commit 82afd0a into kata-containers:master May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grahamwhaley grahamwhaley grahamwhaley left review comments

@teawater teawater teawater approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

@amshinde amshinde Awaiting requested review from amshinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leoluk @grahamwhaley @teawater @jodh-intel