This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
qemu: Add NoReboot config Knob for qemuParams #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding this PR to govmm would allow the following change to kata-runtime to complete the fix (once this PR was vendored in) |
|
thanks @merwick l g tm, could you update the unit test? |
The Kata architecture does not support rebooting VMs (the lifecycle being start/exec/kill) and if a VM is killed (e.g. using sysrq-trigger), the VM does not exit fully and other layers do not notice the state change. Kata needs a way to tell QEMU to run with the '--no-reboot' option so that the guest VM exits and does not attempt to reboot. Add a NoReboot boolean Knob so when Knobs.NoReboot is set, the '--no-reboot' command-line option will be passed to QEMU on startup. Signed-off-by: Liam Merwick <[email protected]>
1 similar comment
jodh-intel
approved these changes
Jul 28, 2020
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Jul 29, 2020
Bring support for '--no-reboot' QEMU parameter (kata-containers/govmm#131) shortlog: qemu: Add NoReboot config Knob for qemuParams Signed-off-by: Liam Merwick <[email protected]>
merwick
added a commit
to merwick/runtime
that referenced
this pull request
Jul 30, 2020
Bring support for '--no-reboot' QEMU parameter (kata-containers/govmm#131) shortlog: qemu: Add NoReboot config Knob for qemuParams Signed-off-by: Liam Merwick <[email protected]>
merwick
added a commit
to merwick/kata-containers
that referenced
this pull request
Jul 30, 2020
Bring support for '--no-reboot' QEMU parameter (kata-containers/govmm#131) shortlog: qemu: Add NoReboot config Knob for qemuParams Signed-off-by: Liam Merwick <[email protected]>
merwick
added a commit
to merwick/kata-containers
that referenced
this pull request
Jul 30, 2020
Bring support for '--no-reboot' QEMU parameter (kata-containers/govmm#131) shortlog: qemu: Add NoReboot config Knob for qemuParams Signed-off-by: Liam Merwick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kata architecture does not support rebooting VMs (the lifecycle
being start/exec/kill) and if a VM is killed (e.g. using sysrq-trigger),
the VM does not exit fully and other layers do not notice the state change.
Kata needs a way to tell QEMU to run with the '--no-reboot' option
so that the guest VM exits and does not attempt to reboot.
Add a NoReboot boolean Knob so when Knobs.NoReboot is set, the '--no-reboot'
command-line option will be passed to QEMU on startup.
Signed-off-by: Liam Merwick [email protected]