Skip to content

Commit

Permalink
gha: k8s-on-aks: Set {create,delete}_aks as steps
Browse files Browse the repository at this point in the history
We've been currently using {create,delete}_aks as jobs.  However, it
means that if the tests fail we'll end up deleting the AKS cluster (as
expected), but not having a way to recreate the cluster without
re-running all jobs, which is a waste of resources.

Fixes: kata-containers#6628

Signed-off-by: Fabiano Fidêncio <[email protected]>
  • Loading branch information
fidencio committed Apr 6, 2023
1 parent abaf881 commit 13d857a
Showing 1 changed file with 10 additions and 26 deletions.
36 changes: 10 additions & 26 deletions .github/workflows/run-k8s-tests-on-aks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,6 @@ on:
type: string

jobs:
create-aks:
strategy:
matrix:
vmm:
- clh
- dragonball
- qemu
uses: ./.github/workflows/create-aks.yaml
with:
name: ${{ inputs.checkout-ref }}-${{ matrix.vmm }}-amd64
secrets: inherit

run-k8s-tests:
strategy:
fail-fast: false
Expand All @@ -38,8 +26,12 @@ jobs:
- dragonball
- qemu
runs-on: ubuntu-latest
needs: create-aks
steps:
- name: Create AKS cluster to test ${{ matrix.vmm }}
uses: ./.github/workflows-create-aks.yaml
with:
name: ${{ inputs.checkout-ref }}-${{ matrix.vmm }}-amd64

- uses: actions/checkout@v3
with:
ref: ${{ inputs.checkout-ref }}
Expand Down Expand Up @@ -85,16 +77,8 @@ jobs:
env:
KATA_HYPERVISOR: ${{ matrix.vmm }}

delete-aks:
strategy:
matrix:
vmm:
- clh
- dragonball
- qemu
needs: run-k8s-tests
if: always()
uses: ./.github/workflows/delete-aks.yaml
with:
name: ${{ inputs.checkout-ref }}-${{ matrix.vmm }}-amd64
secrets: inherit
- name: Delete AKS cluster used to test ${{ matrix.vmm }}
if: always()
uses: ./.github/workflows/delete-aks.yaml
with:
name: ${{ inputs.checkout-ref }}-${{ matrix.vmm }}-amd64

0 comments on commit 13d857a

Please sign in to comment.