This repository has been archived by the owner on May 12, 2021. It is now read-only.
rootfs: Skip installing cargo and rust for docker build #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
amshinde
added a commit
to amshinde/kata-runtime
that referenced
this pull request
Dec 11, 2020
Release included important security updates. References: firecracker-microvm/firecracker#2057 firecracker-microvm/firecracker#2177 Fixes: kata-containers#3095 Depends-on: github.com/kata-containers/osbuilder#508 (cherry picked from commit 11c8c19) Signed-off-by: Archana Shinde <[email protected]>
amshinde
added a commit
to amshinde/kata-runtime
that referenced
this pull request
Dec 11, 2020
Release included important security updates. References: firecracker-microvm/firecracker#2057 firecracker-microvm/firecracker#2177 Fixes: kata-containers#3095 Depends-on: github.com/kata-containers/osbuilder#508 (cherry picked from commit 11c8c19) Signed-off-by: Archana Shinde <[email protected]>
|
@amshinde, wouldn't be better to drop the support for the rust agent entirely in the 1.x repo? |
For the docker build of the rootfs based on golang agent, we still end up installing these packages. Skip these. Fixes kata-containers#507 Signed-off-by: Archana Shinde <[email protected]>
amshinde
force-pushed
the
skip-rust-install-for-goagent
branch
from
c80531b to
b937cf7
Compare
|
/test |
|
@fidencio Yes we could do that, but I also dont want 1.x and 2.x builder scripts diverging too much at this point from maintenance point of view. Would like to see what others think about this. |
chavafg
approved these changes
Dec 15, 2020
jcvenegas
approved these changes
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the docker build of the rootfs based on golang agent,
we still end up installing these packages. Skip these.
Fixes #507
Signed-off-by: Archana Shinde [email protected]