This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this pull request
Jul 21, 2020
Versions is pointing to virtiofs kernel branch, recently it changed and CI is broken. Lets use a new tag for kata. The tag now include the kernel version so will be shown on release notes. Depends-on: github.com/kata-containers/packaging#1098 Fixes: kata-containers#2842 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
/test |
/AzurePipelines |
Supported commands
See additional documentation. |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
likebreath
reviewed
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we normally bump the version in kernel/kata_config_version
when we make changes to the kernel we use in kata?
@jcvenegas we need to bump kata_config_version here |
virtiofs-dev is a branch, now there is a tag based in kernel 5.6 move patches to use the tag name. Depends-on: github.com/kata-containers/runtime#2843 Fixes: kata-containers#1095 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
For new virtiofs path dir name Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
/test |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
likebreath
approved these changes
Jul 22, 2020
@jcvenegas To have a reference of our discuss over slack: It looks like we are only carrying one custom kernel path, a.k.a fix race condition for virtio_vsock. Does it mean the other custom kernel patches we had are already in the updated kernel (e.g. the patch to enable evged)? The previous commits have three custom kernel patches: 8abf130. |
amshinde
approved these changes
Jul 22, 2020
GabyCT
added a commit
to GabyCT/kata-containers
that referenced
this pull request
Aug 18, 2020
This PR updates the versions for the virtiofs kernel branch and as there is a tag based in kernel 5.6 move patches to uses the tag name. This PR is needed to enable CLH CI for kata 2.0. This PR is backporting kata-containers/runtime#2843 and kata-containers/packaging#1098. Fixes kata-containers#532 Signed-off-by: Gabriela Cervantes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtiofs-dev is a branch, now there is a tag
based in kernel 5.6 move patches to use the tag name.
Depends-on: github.com/kata-containers/runtime#2843
Fixes: #1095
Signed-off-by: Jose Carlos Venegas Munoz [email protected]