kata-deploy: Add support for qemu and kernel with virtio-fs 3.0 #710

GabyCT · 2019-09-10T19:46:43Z

This adds the kata deploy for QEMU and kernel with virtio-fs 3.0

Depends-on: github.com/kata-containers/runtime#2052

Fixes #709

Signed-off-by: Gabriela Cervantes [email protected]

egernst

Can you also add the corresponding virtio-fs enabled kernel as well?

GabyCT · 2019-09-12T18:43:23Z

@egernst , I did some changes to the build-kernel.sh script, the first thing was to enable the -e while running the build-kernel.sh script in order to run the experimental kernel, then that it took the corresponding version because as it was it was taking version as 4.19.

GabyCT · 2019-09-12T19:24:36Z

/cc @egernst and @jcvenegas changes applied

GabyCT · 2019-09-12T19:35:58Z

@jcvenegas , I open the #717 about of what we discussed, thanks

This adds the kata deploy for QEMU and kernel with virtio-fs 3.0 Depends-on: github.com/kata-containers/runtime#2052 Fixes kata-containers#709 Signed-off-by: Gabriela Cervantes <[email protected]>

GabyCT · 2019-09-13T12:57:13Z

/test

GabyCT · 2019-09-13T13:44:02Z

/test

jcvenegas

Thank you gaby - added some question and suggestions \cc @egernst

jcvenegas · 2019-09-13T13:53:58Z

release/kata-deploy-binaries.sh

@@ -103,6 +103,15 @@ install_kernel() {
 	)
 }

+#Install experimental kernel asset
+install_experimental_kernel() {
+	info "build experimental kernel"


you will need to enter to the dir of the downloaded packaging kernel.

This script is to ask to create a tarball based on a tag or branch. If we use the the current scripts and someone does a binaries potentially use the old kernel. Additionally I recently sent a patch do it in this way.

Talking offline with you the issue using the the content the issue is that if you do
./kata-deploy-binaries.sh master this will use the packaging of master and not your local changes. Probably would be good to have a flag or argument to say to not use master but what we have locally.

\cc @egernst

the main issue I had in the past was ./kata-deploy-binaries.sh 1.9.0-alpha1 could you take if that works for you @GabyCT ?

@GabyCT I suppose #722 addresses the above issue that @jcvenegas pointed out?
If so, does that PR need to go before this one?

jcvenegas · 2019-09-13T13:56:23Z

kernel/build-kernel.sh

-		#Remove extra 'v'
-		kernel_version="${kernel_version#v}"
+		if [[ ${experimental_kernel} == "true" ]]; then
+			kernel_version="virtio-fs-v0.3"


@egernst should we have defined this in versions.yaml ?
And do
kernel_version="kernel_version=$(get_from_kata_deps "assets.kernel.experimental.version")
If we have hidden here will not not help for people or scripts that use this centralized place of what is used for a kata release.

Yes, ultimately this should end up coming from versions.yaml.

kernel/build-kernel.sh

kata-deploy/scripts/kata-deploy-docker.sh

jcvenegas · 2019-09-13T14:01:19Z

kata-deploy/examples/test-deploy-kata-qemu-virtiofs.yaml

+apiVersion: v1
+kind: Service
+metadata:
+  name: php-apache-kata-qemu-virtiofs


We dont have a test today for this you better try locally to see if we are not missing something here :)

nitkon · 2019-09-13T15:08:01Z

@GabyCT : Are arch specific kernel fragment directory a must to build experimental kernel for virtio-fs?

++ kernel_ver=virtio-fs-v0.3
++ archfragdir=/home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/fragments/powerpc
++ '[' -d /home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/fragments/powerpc ']'
++ config=/home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/powerpc_kata_kvm_virtio-fs-v0.3.x
++ '[' -f /home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/powerpc_kata_kvm_virtio-fs-v0.3.x ']'
++ die 'failed to find default config /home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/powerpc_kata_kvm_virtio-fs-v0.3.x'
++ echo 'ERROR: failed to find default config /home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/powerpc_kata_kvm_virtio-fs-v0.3.x'
ERROR: failed to find default config /home/nitesh/split_patch/src/github.com/kata-containers/packaging/kernel/configs/powerpc_kata_kvm_virtio-fs-v0.3.x
++ exit 1
+ kernel_config_path=

GabyCT · 2019-09-13T15:10:21Z

@nitkon probably @egernst is the person who can answer that as he took that task

This adds QEMU and the kernel with virtiofs 3.0 at the versions.yaml file. Depends-on: github.com/kata-containers/packaging#710 Fixes kata-containers#2051 Signed-off-by: Gabriela Cervantes <[email protected]>

Enable a new configuration file for QEMU with virtiofs 3.0 Depends-on: github.com/kata-containers/packaging#710 Fixes kata-containers#2053 Signed-off-by: Gabriela Cervantes <[email protected]>

GabyCT · 2019-09-13T16:10:13Z

@jcvenegas changes applied, here are the related PRs
kata-containers/runtime#2052
kata-containers/runtime#2054

GabyCT · 2019-09-13T16:32:30Z

/test

nitkon · 2019-09-13T17:35:40Z

kernel/kata_config_version

@@ -1 +1 @@
-49
+50


I see you have bumped the version here but still CI is failing with:

23:01:19 Kernel directory has changes check kernel/kata_config_version changed 23:01:19 ERROR: Please bump version in kernel/kata_config_version 23:01:19 Makefile:24: recipe for target 'test' failed

@jcvenegas any idea of this failure?

@jcvenegas and @nitkon, I just fixed it

GabyCT · 2019-09-13T18:29:24Z

/test

GabyCT · 2019-09-13T19:32:59Z

/AzurePipelines run

azure-pipelines · 2019-09-13T19:33:11Z

Azure Pipelines successfully started running 2 pipeline(s).

Enable a new configuration file for QEMU with virtiofs 3.0 Depends-on: github.com/kata-containers/packaging#710 Fixes kata-containers#2053 Signed-off-by: Gabriela Cervantes <[email protected]>

egernst

Looks good. I wonder if we should wait for a runtime toml to be in place before merging?

addressed issues.

Enable a new configuration file for QEMU with virtiofs 3.0 Depends-on: github.com/kata-containers/packaging#710 Fixes kata-containers#2053 Signed-off-by: Gabriela Cervantes <[email protected]>

GabyCT · 2019-09-17T18:40:57Z

Looks good. I wonder if we should wait for a runtime toml to be in place before merging?

@egernst , I already submitted the changes for the runtime toml kata-containers/runtime#2054

Enable a new configuration file for QEMU with virtiofs 3.0 Depends-on: github.com/kata-containers/packaging#710 Fixes kata-containers#2053 Signed-off-by: Gabriela Cervantes <[email protected]>

GabyCT · 2019-09-17T21:27:30Z

@amshinde , I include the changes at kata-containers/runtime#2054

egernst previously requested changes Sep 10, 2019

View reviewed changes

GabyCT force-pushed the topic/qemuvirt branch 6 times, most recently from c6c0fdc to 5fd590d Compare September 12, 2019 18:38

GabyCT force-pushed the topic/qemuvirt branch from 5fd590d to 0894645 Compare September 12, 2019 19:22

GabyCT changed the title ~~WIP: Add support for qemu with virtio-fs 3.0~~ kata-deploy: Add support for qemu and kernel with virtio-fs 3.0 Sep 12, 2019

GabyCT force-pushed the topic/qemuvirt branch from 0894645 to bd8968a Compare September 12, 2019 19:26

GabyCT requested review from jcvenegas and egernst September 12, 2019 20:43

kata-deploy: Add support for qemu and kernel with virtio-fs 3.0

88d2048

This adds the kata deploy for QEMU and kernel with virtio-fs 3.0 Depends-on: github.com/kata-containers/runtime#2052 Fixes kata-containers#709 Signed-off-by: Gabriela Cervantes <[email protected]>

GabyCT force-pushed the topic/qemuvirt branch from bd8968a to 59fc529 Compare September 13, 2019 13:43

jcvenegas reviewed Sep 13, 2019

View reviewed changes

GabyCT mentioned this pull request Sep 13, 2019

version: Add QEMU and kernel with virtiofs 3.0 kata-containers/runtime#2052

Merged

GabyCT force-pushed the topic/qemuvirt branch from 59fc529 to 2eadcb7 Compare September 13, 2019 15:46

GabyCT mentioned this pull request Sep 13, 2019

configuration: Add QEMU with virtiofs 3.0 support kata-containers/runtime#2054

Merged

nitkon reviewed Sep 13, 2019

View reviewed changes

GabyCT force-pushed the topic/qemuvirt branch 2 times, most recently from df57b6f to 88d2048 Compare September 13, 2019 18:28

egernst reviewed Sep 14, 2019

View reviewed changes

egernst approved these changes Sep 17, 2019

View reviewed changes

jcvenegas approved these changes Sep 18, 2019

View reviewed changes

jcvenegas merged commit 827e85d into kata-containers:master Sep 18, 2019

egernst mentioned this pull request Sep 18, 2019

release: update kata-deploy-binaries virtiofs handling #726

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kata-deploy: Add support for qemu and kernel with virtio-fs 3.0 #710

kata-deploy: Add support for qemu and kernel with virtio-fs 3.0 #710

GabyCT commented Sep 10, 2019 •

edited

Loading

egernst left a comment

GabyCT commented Sep 12, 2019

GabyCT commented Sep 12, 2019

GabyCT commented Sep 12, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

jcvenegas left a comment

jcvenegas Sep 13, 2019

jcvenegas Sep 13, 2019

amshinde Sep 16, 2019

jcvenegas Sep 13, 2019

egernst Sep 14, 2019

jcvenegas Sep 13, 2019

nitkon commented Sep 13, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

nitkon Sep 13, 2019

GabyCT Sep 13, 2019

GabyCT Sep 13, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

azure-pipelines bot commented Sep 13, 2019

egernst left a comment

GabyCT commented Sep 17, 2019

GabyCT commented Sep 17, 2019

kata-deploy: Add support for qemu and kernel with virtio-fs 3.0 #710

kata-deploy: Add support for qemu and kernel with virtio-fs 3.0 #710

Conversation

GabyCT commented Sep 10, 2019 • edited Loading

egernst left a comment

Choose a reason for hiding this comment

GabyCT commented Sep 12, 2019

GabyCT commented Sep 12, 2019

GabyCT commented Sep 12, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

jcvenegas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nitkon commented Sep 13, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GabyCT commented Sep 13, 2019

GabyCT commented Sep 13, 2019

azure-pipelines bot commented Sep 13, 2019

egernst left a comment

Choose a reason for hiding this comment

GabyCT commented Sep 17, 2019

GabyCT commented Sep 17, 2019

GabyCT commented Sep 10, 2019 •

edited

Loading