virtcontainers: Fix the issue of watching console for firecracker

Since firecracker hasn't support console watching by now, so skip watching console if the consoleURL is empty. Fixes: #1970 Signed-off-by: lifupan <[email protected]>
kata-containers · Aug 21, 2019 · 0926c8d · 0926c8d
1 parent 1935bf1
commit 0926c8d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/virtcontainers/proxy.go b/virtcontainers/proxy.go
@@ -239,7 +239,9 @@ func (p *proxyBuiltin) start(params proxyParams) (int, string, error) {
 
 	p.sandboxID = params.id
 
-	if params.debug {
+	// For firecracker, it hasn't support the console watching and it's consoleURL
+	// will be set empty.
+	if params.debug && params.consoleURL != "" {
 		err := p.watchConsole(buildinProxyConsoleProto, params.consoleURL, params.logger)
 		if err != nil {
 			p.sandboxID = ""