Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Commit

Permalink
qemu: Move to qemu 2.11
Browse files Browse the repository at this point in the history
This commit modifies version.yaml to now point to the qemu
2.11 stable version.
It modifies the default QEMU_CMD to be qemu-system-x86_64
instead of qemu-lite-system-x86_64.
And modifies virtcontainers unit tests to now point to the
correct QEMU_CMD.

Fixes: #118.

Signed-off-by: Salvador Fuentes <[email protected]>
  • Loading branch information
chavafg committed Mar 28, 2018
1 parent 4d6e9c9 commit 10c38ae
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 18 deletions.
8 changes: 1 addition & 7 deletions arch/amd64-options.mk
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,4 @@ MACHINETYPE := pc
KERNELPARAMS :=
MACHINEACCELERATORS :=

# The CentOS/RHEL hypervisor binary is not called qemu-lite
ifeq (,$(filter-out centos rhel,$(distro)))
QEMUCMD := qemu-system-x86_64
else
QEMUCMD := qemu-lite-system-x86_64
endif

QEMUCMD := qemu-system-x86_64
5 changes: 2 additions & 3 deletions versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,8 @@ assets:

qemu:
description: "VMM that uses KVM"
url: "https://github.com/kata-containers/qemu"
version: "741f430a960b5b67745670e8270db91aeb083c5f-29"
release: "19360"
url: "https://github.com/qemu/qemu"
version: "stable-2.11"

image:
description: |
Expand Down
6 changes: 3 additions & 3 deletions virtcontainers/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1990,9 +1990,9 @@ func TestProcessListContainer(t *testing.T) {

func createNewPodConfig(hType HypervisorType, aType AgentType, aConfig interface{}, netModel NetworkModel) PodConfig {
hypervisorConfig := HypervisorConfig{
KernelPath: "/usr/share/clear-containers/vmlinux.container",
ImagePath: "/usr/share/clear-containers/clear-containers.img",
HypervisorPath: "/usr/bin/qemu-lite-system-x86_64",
KernelPath: "/usr/share/kata-containers/vmlinux.container",
ImagePath: "/usr/share/kata-containers/kata-containers.img",
HypervisorPath: "/usr/bin/qemu-system-x86_64",
}

netConfig := NetworkConfig{
Expand Down
2 changes: 1 addition & 1 deletion virtcontainers/documentation/api/1.0/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ func Example_createAndStartPod() {
hypervisorConfig := vc.HypervisorConfig{
KernelPath: "/usr/share/clear-containers/vmlinux.container",
ImagePath: "/usr/share/clear-containers/clear-containers.img",
HypervisorPath: "/usr/bin/qemu-lite-system-x86_64",
HypervisorPath: "/usr/bin/qemu-system-x86_64",
}

// Use hyperstart default values for the agent.
Expand Down
6 changes: 3 additions & 3 deletions virtcontainers/example_pod_run_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ func Example_createAndStartPod() {

// Sets the hypervisor configuration.
hypervisorConfig := vc.HypervisorConfig{
KernelPath: "/usr/share/clear-containers/vmlinux.container",
ImagePath: "/usr/share/clear-containers/clear-containers.img",
HypervisorPath: "/usr/bin/qemu-lite-system-x86_64",
KernelPath: "/usr/share/kata-containers/vmlinux.container",
ImagePath: "/usr/share/kata-containers/kata-containers.img",
HypervisorPath: "/usr/bin/qemu-system-x86_64",
}

// Use hyperstart default values for the agent.
Expand Down
2 changes: 1 addition & 1 deletion virtcontainers/qemu_arch_base_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (

const (
qemuArchBaseMachineType = "pc"
qemuArchBaseQemuPath = "/usr/bin/qemu-lite-system-x86_64"
qemuArchBaseQemuPath = "/usr/bin/qemu-system-x86_64"
)

var qemuArchBaseQemuPaths = map[string]string{
Expand Down

0 comments on commit 10c38ae

Please sign in to comment.