ContainerDevice: add AttachError to handle device attach error

Got "docker: Error response from daemon: OCI runtime create failed:
QMP command failed: unknown." when "docker run --privileged" with kata.
The cause is a device got a error when attach to sandbox.

This error doesn't affect the execution of kata.  So just output the
error and record it in AttachError let kataAgent ignore it.

Signed-off-by: Hui Zhu <[email protected]>

virtcontainers/container.go

@@ -237,6 +237,8 @@ type ContainerDevice struct {
 	ID string
 	// ContainerPath is device path displayed in container
 	ContainerPath string
+	// True if device attach get error but ignored
+	AttachError bool
 }
 
 // Container is composed of a set of containers and a runtime environment.
@@ -1142,9 +1144,14 @@ func (c *Container) attachDevices() error {
 	// there's no need to do rollback when error happens,
 	// because if attachDevices fails, container creation will fail too,
 	// and rollbackFailingContainerCreation could do all the rollbacks
-	for _, dev := range c.devices {
+	for id, dev := range c.devices {
 		if err := c.sandbox.devManager.AttachDevice(dev.ID, c.sandbox); err != nil {
-			return err
+			c.devices[id].AttachError = true
+			c.Logger().WithFields(logrus.Fields{
+				"container":            c.id,
+				"device-id":            dev.ID,
+				"device-containerpath": dev.ContainerPath,
+			}).WithError(err).Error("attach device failed but ignored")
 		}
 	}
 

virtcontainers/kata_agent.go

@@ -796,6 +796,9 @@ func (k *kataAgent) handleShm(grpcSpec *grpc.Spec, sandbox *Sandbox) {
 
 func (k *kataAgent) appendDevices(deviceList []*grpc.Device, c *Container) []*grpc.Device {
 	for _, dev := range c.devices {
+		if dev.AttachError {
+			continue
+		}
 		device := c.sandbox.devManager.GetDeviceByID(dev.ID)
 		if device == nil {
 			k.Logger().WithField("device", dev.ID).Error("failed to find device by id")