Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Commit

Permalink
FC: Remove logger.options
Browse files Browse the repository at this point in the history
Firecracker has removed `memory.dirty_pages` metric and `logger.options`
configuration.
Related PR: firecracker-microvm/firecracker#1532.
We need to remove according setting in kata-containers.

Fixes: #2504

Signed-off-by: Penny Zheng <[email protected]>
  • Loading branch information
Pennyzct committed Mar 23, 2020
1 parent 2d89766 commit 37b91b3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
1 change: 0 additions & 1 deletion virtcontainers/fc.go
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,6 @@ func (fc *firecracker) fcSetLogger() error {
Level: &fcLogLevel,
LogFifo: &jailedLogFifo,
MetricsFifo: &jailedMetricsFifo,
Options: []string{},
}

return err
Expand Down
3 changes: 0 additions & 3 deletions virtcontainers/pkg/firecracker/client/models/logger.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions virtcontainers/pkg/firecracker/firecracker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ info:
The API is accessible through HTTP calls on specific URLs
carrying JSON modeled data.
The transport medium is a Unix Domain Socket.
version: 0.19.0
version: 0.21.1
termsOfService: ""
contact:
email: "[email protected]"
Expand Down Expand Up @@ -508,12 +508,6 @@ definitions:
type: boolean
description: Whether or not to include the file path and line number of the log's origin.
default: false
options:
type: array
items:
type: string
description: Additional logging options. Only "LogDirtyPages" is supported.
default: []

MachineConfiguration:
type: object
Expand Down

0 comments on commit 37b91b3

Please sign in to comment.