vc/qemu: add mutex to qmp monitor channel in qmpSetup()

Solve possible race condition in qmpSetup() and qmpShutdown() Fixes: #2139 Signed-off-by: Yves Chan <[email protected]>
kata-containers · Nov 6, 2019 · 5b31282 · 5b31282
1 parent 7d484df
commit 5b31282
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/virtcontainers/qemu.go b/virtcontainers/qemu.go
@@ -19,6 +19,7 @@ import (
 	"path/filepath"
 	"strconv"
 	"strings"
+	"sync"
 	"syscall"
 	"time"
 	"unsafe"
@@ -48,6 +49,7 @@ const romFile = ""
 const defaultDisableModern = false
 
 type qmpChannel struct {
+	sync.Mutex
 	ctx     context.Context
 	path    string
 	qmp     *govmmQemu.QMP
@@ -921,6 +923,9 @@ func (q *qemu) togglePauseSandbox(pause bool) error {
 }
 
 func (q *qemu) qmpSetup() error {
+	q.qmpMonitorCh.Lock()
+	defer q.qmpMonitorCh.Unlock()
+
 	if q.qmpMonitorCh.qmp != nil {
 		return nil
 	}
@@ -949,6 +954,9 @@ func (q *qemu) qmpSetup() error {
 }
 
 func (q *qemu) qmpShutdown() {
+	q.qmpMonitorCh.Lock()
+	defer q.qmpMonitorCh.Unlock()
+
 	if q.qmpMonitorCh.qmp != nil {
 		q.qmpMonitorCh.qmp.Shutdown()
 		// wait on disconnected channel to be sure that the qmp channel has