Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Commit

Permalink
virtcontainers: Add msg to existing utils unit tests
Browse files Browse the repository at this point in the history
Add message to existing unit tests that use arrays and loops for easier
debugging.

Signed-off-by: Chelsea Mafrica <[email protected]>
  • Loading branch information
Chelsea Mafrica committed Aug 12, 2020
1 parent 5debe06 commit 62529e3
Showing 1 changed file with 19 additions and 14 deletions.
33 changes: 19 additions & 14 deletions virtcontainers/utils/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package utils

import (
"fmt"
"io/ioutil"
"os"
"path/filepath"
Expand Down Expand Up @@ -199,10 +200,11 @@ func TestGetVirtDriveName(t *testing.T) {
{18277, "vdzzz"},
}

for _, test := range tests {
for i, test := range tests {
msg := fmt.Sprintf("test[%d]: %+v", i, test)
driveName, err := GetVirtDriveName(test.index)
assert.NoError(err)
assert.Equal(driveName, test.expectedDrive)
assert.NoError(err, msg)
assert.Equal(driveName, test.expectedDrive, msg)
}
}

Expand All @@ -225,11 +227,12 @@ func TestGetSCSIIdLun(t *testing.T) {
{513, 2, 1},
}

for _, test := range tests {
for i, test := range tests {
msg := fmt.Sprintf("test[%d]: %+v", i, test)
scsiID, lun, err := GetSCSIIdLun(test.index)
assert.NoError(err)
assert.Equal(scsiID, test.expectedScsiID)
assert.Equal(lun, test.expectedLun)
assert.NoError(err, msg)
assert.Equal(scsiID, test.expectedScsiID, msg)
assert.Equal(lun, test.expectedLun, msg)
}

_, _, err := GetSCSIIdLun(-1)
Expand All @@ -251,10 +254,11 @@ func TestGetSCSIAddress(t *testing.T) {
{512, "2:0"},
}

for _, test := range tests {
for i, test := range tests {
msg := fmt.Sprintf("test[%d]: %+v", i, test)
scsiAddr, err := GetSCSIAddress(test.index)
assert.NoError(err)
assert.Equal(scsiAddr, test.expectedSCSIAddress)
assert.NoError(err, msg)
assert.Equal(scsiAddr, test.expectedSCSIAddress, msg)
}

_, err := GetSCSIAddress(-1)
Expand Down Expand Up @@ -299,15 +303,16 @@ func TestBuildSocketPath(t *testing.T) {

for i, d := range data {
result, err := BuildSocketPath(d.elems...)
msg := fmt.Sprintf("test[%d]: %+v", i, d)

if d.valid {
assert.NoErrorf(err, "test %d, data %+v", i, d)
assert.NoErrorf(err, "test %d, data %+v", i, d, msg)
} else {
assert.Errorf(err, "test %d, data %+v", i, d)
assert.Errorf(err, "test %d, data %+v", i, d, msg)
}

assert.NotNil(result)
assert.Equal(d.expected, result)
assert.NotNil(result, msg)
assert.Equal(d.expected, result, msg)
}
}

Expand Down

0 comments on commit 62529e3

Please sign in to comment.