virtcontainers: 9p: shares multiple devices with only one export

Use 'remap' behaviour to deal with multiple devices being shared with a 9p export. Fixes the following warning: ``` 9p: Multiple devices detected in same VirtFS export, which might lead to file ID collisions and severe misbehaviours on guest! You should either use a separate export for each device shared from host or use virtfs option 'multidevs=remap'! ``` fixes #2860 Signed-off-by: Julio Montes <[email protected]>
kata-containers · Jul 27, 2020 · 695fa43 · 695fa43
1 parent 50d96b3
commit 695fa43
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/virtcontainers/qemu_arch_base.go b/virtcontainers/qemu_arch_base.go
@@ -472,6 +472,7 @@ func generic9PVolume(volume types.Volume, nestedRun bool) govmmQemu.FSDevice {
 		MountTag:      volume.MountTag,
 		SecurityModel: govmmQemu.None,
 		DisableModern: nestedRun,
+		Multidev:      govmmQemu.Remap,
 	}
 }
 

diff --git a/virtcontainers/qemu_arch_base_test.go b/virtcontainers/qemu_arch_base_test.go
@@ -353,6 +353,7 @@ func TestQemuArchBaseAppend9PVolume(t *testing.T) {
 			Path:          hostPath,
 			MountTag:      mountTag,
 			SecurityModel: govmmQemu.None,
+			Multidev:      govmmQemu.Remap,
 		},
 	}
 

diff --git a/virtcontainers/qemu_test.go b/virtcontainers/qemu_test.go
@@ -211,6 +211,7 @@ func TestQemuAddDeviceFsDev(t *testing.T) {
 			Path:          hostPath,
 			MountTag:      mountTag,
 			SecurityModel: govmmQemu.None,
+			Multidev:      govmmQemu.Remap,
 		},
 	}