qemu: Don't leak file descriptors in case of error

If we take one of the error paths from setupVirtiofsd() after opening the fd variable, the fd.Close() function is not called. Fixes: #2683 Signed-off-by: Christophe de Dinechin <[email protected]>
kata-containers · May 13, 2020 · 7b269ff · 7b269ff
1 parent 80bd453
commit 7b269ff
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/virtcontainers/qemu.go b/virtcontainers/qemu.go
@@ -663,6 +663,7 @@ func (q *qemu) setupVirtiofsd() (err error) {
 	if err != nil {
 		return err
 	}
+	defer fd.Close()
 
 	const sockFd = 3 // Cmd.ExtraFiles[] fds are numbered starting from 3
 	cmd := exec.Command(q.config.VirtioFSDaemon, q.virtiofsdArgs(sockFd)...)