vc: Check error return from storeState

Fixes #2324 This achieves parity with the check on line 293. Signed-off-by: Ted Yu [email protected]
kata-containers · Dec 6, 2019 · 9a15457 · 9a15457
1 parent 00ff99b
commit 9a15457
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/virtcontainers/clh.go b/virtcontainers/clh.go
@@ -304,13 +304,17 @@ func (clh *cloudHypervisor) startSandbox(timeout int) error {
 	}
 	if err := clh.waitVMM(clhTimeout); err != nil {
 		clh.Logger().WithField("error", err).WithField("output", clh.cmdOutput.String()).Warn("cloud-hypervisor init failed")
-		clh.shutdownVirtiofsd()
+		if shutdownErr := clh.shutdownVirtiofsd(); shutdownErr != nil {
+			clh.Logger().WithField("error", shutdownErr).Warn("error shutting down Virtiofsd")
+		}
 		return err
 	}
 
 	clh.state.PID = pid
 	clh.state.state = clhReady
-	clh.storeState()
+	if err = clh.storeState(); err != nil {
+		return err
+	}
 
 	return nil
 }