virtcontainers: qemu: Don't shutdown QMP from hotplug

The QMP shutdown is taken care of by the sandbox release, through a call to hypervisor.disconnect(). By shutting down the QMP at the qemu level directly, we are creating some unrecoverable errors by trying to close an already closed channel. This patch simply removes the faulty code, following the same design other hotplug functions are designed. Fixes #627 Signed-off-by: Sebastien Boeuf <[email protected]>
kata-containers · Aug 23, 2018 · a1787da · a1787da
1 parent 3f45818
commit a1787da
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/virtcontainers/qemu.go b/virtcontainers/qemu.go
@@ -835,12 +835,6 @@ func (q *qemu) hotplugMacvtap(drive VirtualEndpoint) error {
 }
 
 func (q *qemu) hotplugNetDevice(drive VirtualEndpoint, op operation) error {
-	defer func(qemu *qemu) {
-		if q.qmpMonitorCh.qmp != nil {
-			q.qmpMonitorCh.qmp.Shutdown()
-		}
-	}(q)
-
 	err := q.qmpSetup()
 	if err != nil {
 		return err