virtcontainers: tests fix, nit fix

fix tests and nit Signed-off-by: Alex Price <[email protected]>
kata-containers · Apr 29, 2020 · b4833a4 · b4833a4
1 parent db28dcf
commit b4833a4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/containerd-shim-v2/start.go b/containerd-shim-v2/start.go
@@ -38,7 +38,7 @@ func startContainer(ctx context.Context, s *service, c *container) error {
 		go watchSandbox(s)
 
 		// Start watching for oom events
-		go watchOOMEvents(s)
+		go watchOOMEvents(ctx, s)
 	} else {
 		_, err := s.sandbox.StartContainer(c.id)
 		if err != nil {

diff --git a/containerd-shim-v2/wait.go b/containerd-shim-v2/wait.go
@@ -6,6 +6,7 @@
 package containerdshim
 
 import (
+	"context"
 	"path"
 	"time"
 
@@ -128,14 +129,14 @@ func watchSandbox(s *service) {
 	// No need to send async events here.
 }
 
-func watchOOMEvents(s *service) {
+func watchOOMEvents(ctx context.Context, s *service) {
 	if s.sandbox == nil {
 		return
 	}
 
 	for {
 		select {
-		case <-s.ctx.Done():
+		case <-ctx.Done():
 			return
 		default:
 			containerID, err := s.sandbox.GetOOMEvent()

diff --git a/virtcontainers/kata_agent.go b/virtcontainers/kata_agent.go
@@ -2322,9 +2322,8 @@ func (k *kataAgent) getOOMEvent() (string, error) {
 	if err != nil {
 		return "", err
 	}
-	oomEvent, ok := result.(*grpc.OOMEvent)
-	if ok {
-		return oomEvent.ContainerId, err
+	if oomEvent, ok := result.(*grpc.OOMEvent); ok {
+		return oomEvent.ContainerId, nil
 	}
 	return "", err
 }