virtcontainers: fix kernel modules annotations

Casting in golang doesn't return a pointer to the structure, instead a new structure is instantiated. This patch is to update the old structure with the new one in order to apply the changes. fixes #2016 Signed-off-by: Julio Montes <[email protected]>
kata-containers · Aug 30, 2019 · c8e5659 · c8e5659
1 parent eb0a3d2
commit c8e5659
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/virtcontainers/pkg/oci/utils.go b/virtcontainers/pkg/oci/utils.go
@@ -455,9 +455,10 @@ func addAssetAnnotations(ocispec CompatOCISpec, config *vc.SandboxConfig) {
 	}
 
 	if value, ok := ocispec.Annotations[vcAnnotations.KernelModules]; ok {
-		if c, ok := config.AgentConfig.(*vc.KataAgentConfig); ok {
+		if c, ok := config.AgentConfig.(vc.KataAgentConfig); ok {
 			modules := strings.Split(value, KernelModulesSeparator)
 			c.KernelModules = modules
+			config.AgentConfig = c
 		}
 	}
 }

diff --git a/virtcontainers/pkg/oci/utils_test.go b/virtcontainers/pkg/oci/utils_test.go
@@ -14,9 +14,11 @@ import (
 	"path/filepath"
 	"runtime"
 	"strconv"
+	"strings"
 	"testing"
 
 	"github.com/cri-o/cri-o/pkg/annotations"
+	spec "github.com/opencontainers/runtime-spec/specs-go"
 	specs "github.com/opencontainers/runtime-spec/specs-go"
 	"github.com/stretchr/testify/assert"
 	"golang.org/x/sys/unix"
@@ -790,3 +792,42 @@ func TestMain(m *testing.M) {
 
 	os.Exit(m.Run())
 }
+
+func TestAddAssetAnnotations(t *testing.T) {
+	assert := assert.New(t)
+
+	expectedAnnotations := map[string]string{
+		vcAnnotations.KernelPath:    "/abc/rgb/kernel",
+		vcAnnotations.ImagePath:     "/abc/rgb/image",
+		vcAnnotations.InitrdPath:    "/abc/rgb/initrd",
+		vcAnnotations.KernelHash:    "3l2353we871g",
+		vcAnnotations.ImageHash:     "52ss2550983",
+		vcAnnotations.AssetHashType: "sha",
+	}
+
+	config := vc.SandboxConfig{
+		Annotations: make(map[string]string),
+		AgentConfig: vc.KataAgentConfig{},
+	}
+
+	ocispec := CompatOCISpec{
+		Spec: spec.Spec{
+			Annotations: expectedAnnotations,
+		},
+	}
+
+	addAssetAnnotations(ocispec, &config)
+	assert.Exactly(expectedAnnotations, config.Annotations)
+
+	expectedAgentConfig := vc.KataAgentConfig{
+		KernelModules: []string{
+			"e1000e InterruptThrottleRate=3000,3000,3000 EEE=1",
+			"i915 enable_ppgtt=0",
+		},
+	}
+
+	ocispec.Annotations[vcAnnotations.KernelModules] = strings.Join(expectedAgentConfig.KernelModules, KernelModulesSeparator)
+	addAssetAnnotations(ocispec, &config)
+	assert.Exactly(expectedAgentConfig, config.AgentConfig)
+
+}