device: Add extra checks

Add parameter checks to `waitForDevice()`. Signed-off-by: James O. D. Hunt <[email protected]>
kata-containers · Jul 18, 2019 · d4f205d · d4f205d
1 parent faa6cb0
commit d4f205d
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/device.go b/device.go
@@ -7,6 +7,7 @@
 package main
 
 import (
+	"errors"
 	"fmt"
 	"io/ioutil"
 	"os"
@@ -288,6 +289,18 @@ func updateSpecDeviceList(device pb.Device, spec *pb.Spec) error {
 type checkUeventCb func(uEv *uevent.Uevent) bool
 
 func waitForDevice(devicePath, deviceName string, checkUevent checkUeventCb) error {
+	if devicePath == "" {
+		return errors.New("need device path")
+	}
+
+	if deviceName == "" {
+		return errors.New("need device name")
+	}
+
+	if checkUevent == nil {
+		return errors.New("invalid uevent handler")
+	}
+
 	uEvHandler, err := uevent.NewHandler()
 	if err != nil {
 		return err