virtcontainers: unmount host mounts if container can't be created

Mount points, like `resolv.conf` and `hostname` are left in the host when the cgroup creation fails. Use `unmountHostMounts()` and `bindUnmountContainerRootfs()` in the rollback function that is called when container's creation fails. fixes #2108 Signed-off-by: Julio Montes <[email protected]>
kata-containers · Oct 11, 2019 · eca7bd2 · eca7bd2
1 parent c7b4c5e
commit eca7bd2
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/virtcontainers/container.go b/virtcontainers/container.go
@@ -857,6 +857,12 @@ func (c *Container) rollbackFailingContainerCreation() {
 	if err := c.removeDrive(); err != nil {
 		c.Logger().WithError(err).Error("rollback failed removeDrive()")
 	}
+	if err := c.unmountHostMounts(); err != nil {
+		c.Logger().WithError(err).Error("rollback failed unmountHostMounts()")
+	}
+	if err := bindUnmountContainerRootfs(c.ctx, kataHostSharedDir(), c.sandbox.id, c.id); err != nil {
+		c.Logger().WithError(err).Error("rollback failed bindUnmountContainerRootfs()")
+	}
 }
 
 func (c *Container) checkBlockDeviceSupport() bool {