This repository has been archived by the owner on May 12, 2021. It is now read-only.

Replace the resourceStorage implementation #1099

Closed

sameo opened this issue Jan 8, 2019 · 1 comment

Assignees

sameo commented Jan 8, 2019

Description of problem

The resourceStorage implementation is a wide spread dependency and prevents several key components (e.g. hypervisors) to be moved into their own package.

Expected result

Create a new store package that provides a storage implementation for virtcontainers, with the following features:

Simplicity: The API should be short and simple.
Transparency: The core virtcontainers code should not care about
the storage backend details.
Extensibility: It should be easily extensible to add non local and in
memory backends.

The text was updated successfully, but these errors were encountered:

sameo self-assigned this

sameo mentioned this issue

virtcontainers code base is monolithic #1059

Closed

8 tasks

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Initial conversion to Stores

e7cf9cd

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

Contributor

jodh-intel commented Jan 8, 2019

Related to the following PRs:

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

f4716e7

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

ce86229

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

4f70d09

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

5b2c3e5

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

3182ac1

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

b6c4cc3

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

afe5ace

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

722b7df

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

fe078dd

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

73b15c6

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

b811a20

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

c8e3852

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

6c6094b

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

fabbd8a

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

d33aa30

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

0d8c289

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

1d84b3a

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

028fb46

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

791c610

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

018d707

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

2f10af4

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

19506e3

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

0296e9a

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

1ffc053

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

1cab618

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

a16b500

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

5a5841e

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

058875c

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

a0ecfa9

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

59baa51

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

a20b024

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Conversion to Stores

67e2faa

We convert the whole virtcontainers code to use the store package
instead of the resource_storage one. The resource_storage removal will
happen in a separate change for a more logical split.

This change is fairly big but mostly does not change the code logic.
What really changes is when we create a store for a container or a
sandbox. We now need to explictly do so instead of just assigning a
filesystem{} instance. Other than that, the logic is kept intact.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

1441fba

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

sameo pushed a commit to sameo/runtime-1 that referenced this issue


          virtcontainers: Remove the resource storage original implementation

f8e7e30

Now that we converted the virtcontainers code to the store package, we
can remove all the resource storage old code.

Fixes: kata-containers#1099

Signed-off-by: Samuel Ortiz <[email protected]>

egernst closed this as completed in

fad23ea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.