Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

shimv2 testcase always failed after libcontainer updated to latest #1493

Closed
lifupan opened this issue Apr 8, 2019 · 0 comments · Fixed by #1494
Closed

shimv2 testcase always failed after libcontainer updated to latest #1493

lifupan opened this issue Apr 8, 2019 · 0 comments · Fixed by #1494

Comments

@lifupan
Copy link
Member

lifupan commented Apr 8, 2019

Description of problem

For much info, please kata-containers/agent#502

Expected result

(replace this text with an explanation of what you thought would happen)

Actual result

(replace this text with details of what actually happened)


(replace this text with the output of the kata-collect-data.sh script, after
you have reviewed its content to ensure it does not contain any private
information).

lifupan added a commit to lifupan/kata-runtime that referenced this issue Apr 8, 2019
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.

Fixes:kata-containers#1493

Depends-on:kata-containers/agent#526

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Apr 8, 2019
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.

Fixes:kata-containers#1493

Depends-on:github.com/kata-containers/agent/pull/526

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Apr 8, 2019
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.

Fixes:kata-containers#1493

Depends-on:github.com/kata-containers/agent/pull/526

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Apr 10, 2019
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.

Fixes:kata-containers#1493

Depends-on:github.com/kata-containers/agent/pull/526

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Apr 11, 2019
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.

Fixes:kata-containers#1493

Signed-off-by: lifupan <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Apr 16, 2019
There is no need to send another SIGKILL signal following
SIGTERM signal, otherwise, sending the SIGKILL signal would
get failed since the container process would has been terminated
by the previous SIGTERM signal.

Fixes:kata-containers#1493

Signed-off-by: lifupan <[email protected]>
ganeshmaharaj pushed a commit to ganeshmaharaj/kata-runtime that referenced this issue Apr 16, 2019
shimv2: fix the issue of stop container failed
(cherry picked from commit c08976e)

Fixes:kata-containers#1493

Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant