Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

document swarm docker version more clearly #181

Closed
jodh-intel opened this issue Apr 4, 2018 · 2 comments
Closed

document swarm docker version more clearly #181

jodh-intel opened this issue Apr 4, 2018 · 2 comments
Assignees

Comments

@jodh-intel
Copy link
Contributor

We currently document that docker 1.12 is required for using swarm in the versions database:

However, that's not strictly true since "basic" swarm works:

We need to update the versions database to clarify that somehow. I vote for adding a reference to the issue in question using a new swarm-issue value like this:

  docker:
    description: "Moby project container manager"
    notes: "Docker Swarm requires an older version of Docker."
    url: "https://github.com/moby/moby"
    version: "v17.12-ce"
    meta:
      swarm-version: "1.12.1"
      swarm-issue: "https://github.com/kata-containers/runtime/issues/175"
@GabyCT
Copy link
Contributor

GabyCT commented Apr 17, 2018

@jodh-intel, I have a question regarding this issue, it is possible to launch Swarm replicas with Docker 17.12.1, however, it is not possible to ping among the replicas mainly because of issue #175. The tests that were added check basics like interface names (#175). By using the version 1.12.1 is possible to ping among the replicas and do more complex stuff. Should I change the versions.yaml with docker 17.12.1? Thanks for everything.

zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
With this patch the runtime will communicate to the agent the
number of vCPUs that were hot added, allowing to the agent online all vCPUs.
The agent will try to online all vCPUs 10 times, waiting 100 milliseconds
in each iteration, this is needed since when the runtime calls to QMP
`device_add`, QEMU doesn't allocate all vCPUs inmediatelly.

fixes kata-containers#181

Signed-off-by: Julio Montes <[email protected]>
@GabyCT
Copy link
Contributor

GabyCT commented Jul 17, 2019

Closing this issue as we make a reference about which version is working with swarm https://github.com/kata-containers/runtime/blob/master/versions.yaml#L209, also we specify in the Limitations about swarm testing https://github.com/kata-containers/documentation/blob/master/Limitations.md

@GabyCT GabyCT closed this as completed Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants