Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

do not stop a guest multiple times #1958

Closed
bergwolf opened this issue Aug 13, 2019 · 0 comments · Fixed by #1959
Closed

do not stop a guest multiple times #1958

bergwolf opened this issue Aug 13, 2019 · 0 comments · Fixed by #1959
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@bergwolf
Copy link
Member

Description of problem

With shimv2 + sandbox monitor, we might call stopsandbox multiple times. Only the first time it can succeed. For later stop, we can just ignore them and return success.
@bergwolf bergwolf added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Aug 13, 2019
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 13, 2019
@bergwolf
qemu: do not try to stop qemu multiple times
b58ab66 
We've cleaned it up the first time. Future stop will
only fail.

Fixes: kata-containers#1958
Signed-off-by: Peng Tao <[email protected]>
@bergwolf bergwolf mentioned this issue Aug 13, 2019
Merged
egernst pushed a commit to egernst/runtime that referenced this issue Aug 29, 2019
@bergwolf
qemu: do not try to stop qemu multiple times
5737f80 
We've cleaned it up the first time. Future stop will
only fail.

Fixes: kata-containers#1958
Signed-off-by: Peng Tao <[email protected]>
vijaydhanraj pushed a commit to vijaydhanraj/runtime that referenced this issue Sep 3, 2019
@bergwolf @vijaydhanraj
qemu: do not try to stop qemu multiple times
b65b589 
We've cleaned it up the first time. Future stop will
only fail.

Fixes: kata-containers#1958
Signed-off-by: Peng Tao <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

qemu: do not try to stop qemu multiple times bergwolf/kata-runtime
1 participant
@bergwolf