Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

didn't cleanup the container config from sandbox when create container failed #1997

Closed
lifupan opened this issue Aug 22, 2019 · 0 comments · Fixed by #1998
Closed

didn't cleanup the container config from sandbox when create container failed #1997

lifupan opened this issue Aug 22, 2019 · 0 comments · Fixed by #1998
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@lifupan
Copy link
Member

lifupan commented Aug 22, 2019

Description of problem

When create container failed for sandbox, we should do cleanup of the container config from
sandbox.config.Containers, otherwise, the following new create container would update the resources included this previous failed container resources.

Expected result

(replace this text with an explanation of what you thought would happen)

Actual result

(replace this text with details of what actually happened)

@lifupan lifupan added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Aug 22, 2019
lifupan added a commit to lifupan/kata-runtime that referenced this issue Aug 22, 2019
When create container failed, it should delete the container
config from sandbox, otherwise, the following new creating container
would get a wrong resources caculating which would contain the previous
failed container resources such as memory and cpu.

Fixes: kata-containers#1997

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Aug 22, 2019
When create container failed, it should delete the container
config from sandbox, otherwise, the following new creating container
would get a wrong resources caculating which would contain the previous
failed container resources such as memory and cpu.

Fixes: kata-containers#1997

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Aug 22, 2019
When create container failed, it should delete the container
config from sandbox, otherwise, the following new creating container
would get a wrong resources caculating which would contain the previous
failed container resources such as memory and cpu.

Fixes: kata-containers#1997

Signed-off-by: lifupan <[email protected]>
lifupan added a commit to lifupan/kata-runtime that referenced this issue Aug 22, 2019
When create container failed, it should delete the container
config from sandbox, otherwise, the following new creating container
would get a wrong resources caculating which would contain the previous
failed container resources such as memory and cpu.

Fixes: kata-containers#1997

Signed-off-by: lifupan <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Aug 29, 2019
When create container failed, it should delete the container
config from sandbox, otherwise, the following new creating container
would get a wrong resources caculating which would contain the previous
failed container resources such as memory and cpu.

Fixes: kata-containers#1997

Signed-off-by: lifupan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant