Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Use a map for BlockIndex #2007

Closed
darfux opened this issue Aug 28, 2019 · 0 comments · Fixed by #2008
Closed

Use a map for BlockIndex #2007

darfux opened this issue Aug 28, 2019 · 0 comments · Fixed by #2008
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@darfux
Copy link
Contributor

darfux commented Aug 28, 2019

Which feature do you think can be improved?
Use a map to record BlockIndex of SandboxState instead of the current auto increment integer.

How can it be improved?
This makes us able to reuse the index of detached device. So if a container restarts a large number of times, it will not reach the limit of device(such as maxSCSIDevices).

@darfux darfux added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Aug 28, 2019
darfux added a commit to darfux/runtime that referenced this issue Aug 28, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Aug 28, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Aug 30, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Sep 4, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Sep 4, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Sep 10, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Sep 10, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Dec 4, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Dec 4, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Dec 5, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Dec 18, 2019
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Jan 21, 2020
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Jan 21, 2020
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
darfux added a commit to darfux/runtime that referenced this issue Mar 3, 2020
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
evanfoster pushed a commit to evanfoster/runtime that referenced this issue Mar 9, 2020
This allows to reuse detached block index and ensures that the
index will not reach the limit of device(such as `maxSCSIDevices`)
after restarting containers many times in one pod.

Fixes: kata-containers#2007
Signed-off-by: Li Yuxuan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant