Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Check return value from os.MkdirAll in virtiofsdArgs #2297

Closed
tedyu opened this issue Nov 30, 2019 · 0 comments · Fixed by #2298
Closed

Check return value from os.MkdirAll in virtiofsdArgs #2297

tedyu opened this issue Nov 30, 2019 · 0 comments · Fixed by #2298
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@tedyu
Copy link
Contributor

tedyu commented Nov 30, 2019

Description of problem

In cloudHypervisor#virtiofsdArgs, if sourcePath doesn't exist, we try to create the directory.

However, return value from os.MkdirAll is not checked.

Expected result

Check the return value and return error if error is not nil.

Actual result
@tedyu tedyu added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Nov 30, 2019
tedyu pushed a commit to tedyu/runtime that referenced this issue Nov 30, 2019
@yutedz
vc: Check return value from os.MkdirAll in virtiofsdArgs
628799a 
Fixes kata-containers#2297

Signed-off-by: Ted Yu [email protected]
@tedyu tedyu mentioned this issue Nov 30, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vc: Check return value from os.MkdirAll in virtiofsdArgs tedyu/runtime
1 participant
@tedyu