Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Codes misunderstanding left after rename pod to sandbox #230

Closed
jshachm opened this issue Apr 18, 2018 · 0 comments
Closed

Codes misunderstanding left after rename pod to sandbox #230

jshachm opened this issue Apr 18, 2018 · 0 comments

Comments

@jshachm
Copy link
Member

jshachm commented Apr 18, 2018

Description of problem

After we rename pod to sandbox, still there are some codes left which will cause some misunderstanding.Such as,p in short of pod left in sandbox.go.So we need to channge it into s in short of sandbox.

like the code below:

func (p *Sandbox) ID() string {
       return p.id
@jshachm jshachm mentioned this issue Apr 18, 2018
Merged
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
network: Don't remove network routes or DNS when destroying sandbox
4bcacdc 
The network routes will always be removed when the associated
interfaces are going to be removed. Same thing for DNS.  It is
safer to leave this to each interface removal.

Fixes kata-containers#230

Signed-off-by: Sebastien Boeuf <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jshachm