Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Version support check is ineffective in createSandbox #2311

Closed
tedyu opened this issue Dec 3, 2019 · 1 comment · Fixed by #2312
Closed

Version support check is ineffective in createSandbox #2311

tedyu opened this issue Dec 3, 2019 · 1 comment · Fixed by #2312

Comments

@tedyu
Copy link
Contributor

tedyu commented Dec 3, 2019

Description of problem

In cloudHypervisor#createSandbox, the check against major and minor supported versions cannot handle either version being 0.

Expected result

The check should cover either major or minor version being 0.

Actual result
@tedyu tedyu added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Dec 3, 2019
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 3, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
ef1f8cf 
Fixes kata-containers#2311

Signed-off-by: Ted Yu <[email protected]>
@tedyu tedyu mentioned this issue Dec 3, 2019
Merged
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 3, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
52192df 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu [email protected]
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 4, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
5e77dd0 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu [email protected]
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 4, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
6124462 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu [email protected]
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 4, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
f60e4e4 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu [email protected]
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 4, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
cec7661 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu [email protected]
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 4, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
4e99de6 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu [email protected]
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 9, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
4f641d4 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu <[email protected]>
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 10, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
dd354f3 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu <[email protected]>
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 19, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
f171180 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu <[email protected]>
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 26, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
4643b3e 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu <[email protected]>
tedyu pushed a commit to tedyu/runtime that referenced this issue Dec 29, 2019
@yutedz
vc: Version support check is ineffective in createSandbox
7e47046 
Fixes kata-containers#2311

If major version matches max supported major, we continue comparing the minor version.

Signed-off-by: Ted Yu <[email protected]>
@fidencio fidencio added backport and removed bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Apr 21, 2020
@fidencio
Copy link
Member

I've added the "backport" label as it may be material for. at least 1.11.0 stable release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vc: Version support check is ineffective in createSandbox tedyu/runtime
2 participants
@fidencio @tedyu